fix(aria-valid-attr-value): report empty values as incomplete #3635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Sep 5, 2022
| @@ -106,30 +107,35 @@ function ariaValidAttrValueEvaluate(node, options, virtualNode) { | |||
| } catch (e) { | |||
| needsReview = `${attrName}="${attrValue}"`; | |||
| messageKey = 'idrefs'; | |||
| return; | |||
There was a problem hiding this comment.
Avoid getting into that if statement below, as we don't want both needsReview and invalid set.
WilcoFiers
commented
Sep 5, 2022
| } | ||
| }); | ||
|
|
||
| if (needsReview) { |
There was a problem hiding this comment.
Report invalid before needsReview.
WilcoFiers
commented
Sep 5, 2022
| @@ -1,48 +1,72 @@ | |||
| describe('aria-required-attr', function() { | |||
| describe('aria-required-attr', function () { | |||
There was a problem hiding this comment.
Check didn't change, just want to better prove empty values are not allowed under this check.
straker
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no real difference between an empty ARIA attribute, a null attribute, and not having the attribute at all. Failing empty ARIA attributes therefor seems a little strict. They shouldn't be passed either though, since it is pretty easy to mistakenly assume
<input aria-invalid>means the input is invalid. Reportingincompleteseems more appropriate. This PR makes that change, along with:aria-invalidis now reported as incomplete when empty, rather than passedCloses issue: #3489