Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axe.d.ts): updates type definition for Rule to add reviewOnFail #3521

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

Capocaccia
Copy link
Contributor

…meter reviewOnFail

Updates the type definition file to add reviewOnFail to Rule type. ReviewOnFail is a valid configuration parameter that can be passed into the configure command in an array of rules.

Example:

axe.configure({ rules: [ { id: 'new-rule', reviewOnFail: true // ... } ] })

Closes issue:

No issue attached.

@Capocaccia Capocaccia requested a review from a team as a code owner June 27, 2022 17:29
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2022

CLA assistant check
All committers have signed the CLA.

@straker straker changed the title updates type definition for Rule to add additional configuration para… fix(axe.d.ts): updates type definition for Rule to add reviewOnFail Jun 27, 2022
@straker
Copy link
Contributor

straker commented Jun 27, 2022

Thanks for the pr. I'll look at the failing tests. I also updated the pr title for you to reflect our commit message policy (we follow conventional commits)

@Capocaccia
Copy link
Contributor Author

Thanks for the pr. I'll look at the failing tests. I also updated the pr title for you to reflect our commit message policy (we follow conventional commits)

You are welcome. I took at look at the logs in CircleCI and they appear to be unrelated to my change. Might just be some test flake.

@straker
Copy link
Contributor

straker commented Jun 28, 2022

Reviewed for security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants