fix(autocomplete-valid): allow synonyms of on/off autocomplete attribute values #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your inputs on the issue @WilcoFiers ! Please let me know if I need to make any changes to this pull request. If you think it is okay, could you please add |
|
I ran the integration tests after making my changes locally and they have passed successfully using this command |
WilcoFiers
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
This looks excellent! Thank you so much for your contribution @maruthimohan.
|
For the record; I reviewed this PR for security. |
straker
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the
input'sautocompleteattribute to accept synonyms ofon/offvalues. Earlier, theaxe-corerules would not allow any value other than those accepted as per the standards for theautocompleteattribute.Closes issue: #3188