fix(utils): fix warning thrown by Webpack #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dylanb
previously approved these changes
Mar 16, 2021
Fixes a warning thrown by Webpack for using "require" without importing anything. Warning reads "require function is used in a way in which dependencies cannot be statically extracted" Closes issue dequelabs#2840
istateside
force-pushed
the
fix-static-dependency-warning
branch
from
d907879
to
8a68a82
Compare
istateside
changed the title
| @@ -24,7 +24,7 @@ if (!_rng && _crypto && _crypto.getRandomValues) { | |||
| } | |||
|
|
|||
| try { | |||
| if (!_rng && require) { | |||
| if (!_rng) { | |||
There was a problem hiding this comment.
This change worries me. How does this change effect other supported environments?
There was a problem hiding this comment.
Before, if require wasn't defined, it would skip the conditional and continue on. Now, if require isn't defined, an error will be thrown by require('crypto') on the next line, which will be caught by the try/catch block. I don't think this changes the execution in a meaningful way
There was a problem hiding this comment.
Thanks for the explanation.
dylanb
approved these changes
Mar 18, 2021
|
@WilcoFiers please merge if you are ok with this too |
WilcoFiers
approved these changes
Mar 19, 2021
straker
pushed a commit
that referenced
this pull request
Apr 1, 2021
Fixes a warning thrown by Webpack for using "require" without importing anything. Warning reads "require function is used in a way in which dependencies cannot be statically extracted" Closes issue #2840
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2840 (comment)
This PR updates a line added in the recent 4.1.3 release. Webpack is throwing a warning when this library is included in a bundle, pointed at the given line.
I believe what's happening here is that Webpack sees the word "require", but doesn't understand that it's not being used to actually "require" something. Webpack doesn't know what to do with it, so it throws a warning.
The line is already wrapped in a try, so it should be fine to just drop the
&& requirein the condition. Ifconst nodeCrypto = require('crypto')fails, the error will get caught and we can continue on.Closes issue: #2840