Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heading-order): allow partial context to pass #2622

Merged
merged 9 commits into from
Nov 24, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 3, 2020

These changes allow partial heading-order context to pass. It will also handle iframes if they are included in the context or not.

Closes issue: #728

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 3, 2020 18:37
@straker
Copy link
Contributor Author

straker commented Nov 4, 2020

I have tried to debug this in IE11 for hours but can't figure out what's going on. It doesn't help that it's flakey for some reason. Best I can figure is that the iframe isn't running / returning axe results to the parent and so the iframe results are completely missing from the results object. Sometimes (rarely) the iframe times out and we get an error "Axe in frame timed out," but this doesn't happen every time the iframe results aren't in the results object.

A lot of the times when devtools are open the tests pass magically, or when I add console logs or debuggers. This makes me think it's a race condition, but I can't figure out where the problem is occurring in our integration runner.js script.

It also always passes if you just run the heading-order integration tests, so it has something to do with all the tests running before it...

lib/checks/navigation/heading-order-evaluate.js Outdated Show resolved Hide resolved
lib/checks/navigation/heading-order-after.js Outdated Show resolved Hide resolved
lib/checks/navigation/heading-order-evaluate.js Outdated Show resolved Hide resolved
lib/checks/navigation/heading-order-evaluate.js Outdated Show resolved Hide resolved
lib/checks/navigation/heading-order-after.js Show resolved Hide resolved
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor points

lib/checks/navigation/heading-order-after.js Show resolved Hide resolved
lib/checks/navigation/heading-order-after.js Show resolved Hide resolved
@straker straker merged commit f8baee6 into develop Nov 24, 2020
@straker straker deleted the heading-order-context branch November 24, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants