Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-contrast): dont error for floating element #2444

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Aug 11, 2020

Found this as a bug when testing on a site. The variable is reassigned to an empty array under certain conditions.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

Found this as a bug when testing on a site.
@straker straker requested a review from a team as a code owner August 11, 2020 21:43
@straker straker changed the title Update reduce-to-elements-below-floating.js fix(reduce-to-elements-below-floating): dont error for floating element Aug 11, 2020
@straker straker changed the title fix(reduce-to-elements-below-floating): dont error for floating element fix(color-contrast): dont error for floating element Aug 11, 2020
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this?

@straker
Copy link
Contributor Author

straker commented Aug 11, 2020

Probably. I'll have to go dig around the color-contrast test code for where this code would be triggered

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely need a test. Clearly some code path isn't tested.

@straker straker merged commit 7b58c91 into develop Aug 14, 2020
@straker straker deleted the straker-patch-1 branch August 14, 2020 16:47
straker added a commit that referenced this pull request Sep 8, 2020
* Update reduce-to-elements-below-floating.js

Found this as a bug when testing on a site.

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants