fix(skip-link): identify as skip-link only if the link is offscreen #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Mar 4, 2020
WilcoFiers
approved these changes
Mar 6, 2020
straker
added a commit
that referenced
this pull request
Mar 6, 2020
…2079) * fix(skip-link): identify as skip-link only if the link is offscreen * fix region test * revert changes, only check offscreen in skip-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few false positives with normal links (
<a href="/#target"></a>) being identified as skip links. This changes the definition of a skip link to only include links which are offscreen.Closes issue: #2069, #2055
Reviewer checks
Required fields, to be filled out by PR reviewer(s)