Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Basque (eu) translation #1964

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

aitorla
Copy link
Contributor

@aitorla aitorla commented Jan 5, 2020

Adds Danish localization of Ace.

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@aitorla aitorla requested a review from a team as a code owner January 5, 2020 06:57
@WilcoFiers
Copy link
Contributor

@aitorla Thank you so much for putting this together! Really cool. Just to give you some info on these. We are looking for someone independent who can help us review this. It's a little hard to predict how much time that would take, these pull requests tend to take a while to get merged. But it will, for sure!

Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long, just 1 thing

locales/eu.json Outdated
Comment on lines 772 to 776
"incompleteFallbackMessage": {
"undefined": {
"failureMessage": "Gorabehera hauek zuzentzea (guztiak):{{~it:value}}\n {{=value.split('\\n').join('\\n ')}}{{~}}"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The incompleteFallbackMessage should just be a string instead of an object (I think we had generated it wrongly before). See https://github.com/dequelabs/axe-core/blob/develop/locales/fr.json#L841 for an example. Also, it should be different than the failureSummaries message.

The English version of incompleteFallbackMessage:

axe couldn't tell the reason. Time to break out the element inspector!

@straker
Copy link
Contributor

straker commented Mar 24, 2020

@aitorla

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@straker straker dismissed their stale review April 3, 2020 15:09

Resolved

@WilcoFiers WilcoFiers merged commit 176cf82 into dequelabs:develop Apr 3, 2020
@WilcoFiers
Copy link
Contributor

Merging this PR, as it has been open for a very long time. If there are any further changes / improvements that need to be made, feel free to open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants