Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(only-listitem): add message about invalid role on li elements #1954

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 19, 2019

Add a new message when an <li> element has a role that is not listitem. I also heavily refactored and simplified the code because it was super confusing to read through and try to figure out what was going on (lots of negation statements, a reduce that wasn't needed, confusing logic, didn't make use of aria.getRole, etc.).

Closes issue: #1919

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner December 19, 2019 19:18
lib/checks/lists/only-listitems.json Outdated Show resolved Hide resolved
lib/checks/lists/only-listitems.js Show resolved Hide resolved
@straker straker merged commit c3049ab into develop Jan 7, 2020
@straker straker deleted the listRole branch January 7, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants