Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fieldset, group-labelledby): deprecate fieldset and group-labelledby checks #1740

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 31, 2019

Deprecating checks used only in the newly deprecated radiogroup and checkboxgroup rules. The deprecated property doesn't really do anything in the code, but I figured it would be nice to have so we can search for the term and get hits on rules and checks.

Closes issue: #1733

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 31, 2019 17:10
@straker straker changed the title feat(fieldset, group-labelledby): deprecated fieldset and group-labelledby checks feat(fieldset, group-labelledby): deprecate fieldset and group-labelledby checks Aug 1, 2019
lib/checks/forms/group-labelledby.json Outdated Show resolved Hide resolved
@straker straker merged commit ec9b762 into develop Aug 13, 2019
@straker straker deleted the deprecateChecks branch August 13, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants