New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: arguments for gather function in build template #1605

Merged

jeeyyy merged 1 commit into develop from fix-gather-arguments

Jun 4, 2019

Contributor

jeeyyy commented Jun 3, 2019

Noticed that the gather function in Rule, takes 2 arguments (See - https://github.com/dequelabs/axe-core/blob/develop/lib/core/base/rule.js#L386), but the build template for any override provided in the rule spec, passes the wrong number of arguments.

Closes issue: NA

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

Follows the commit message policy, appropriate for next version
Has documentation updated, a DU ticket, or requires no documentation change
Includes new tests, or was unnecessary
Code is reviewed for security by: << Name here >>


          fix: arguments for gather

6af4496

jeeyyy mentioned this pull request

feat(rule): add before function callback to rule spec #1606

Closed

4 tasks

straker approved these changes

View reviewed changes

jeeyyy merged commit 753ecf4 into develop

jeeyyy deleted the fix-gather-arguments branch

June 20, 2019 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet