test: fix tests failing in IE11 #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously requested changes
May 15, 2019
stephenmathieson
previously approved these changes
May 15, 2019
scurker
reviewed
May 15, 2019
jeeyyy
approved these changes
May 16, 2019
stephenmathieson
added a commit
that referenced
this pull request
May 16, 2019
* develop: test: fix test for Safari (#1557) test: fix flakey test (#1573) test: fix tests failing in IE11 (#1570) test: only run IE11 tests in appveyor (#1571) chore: run prettier and format (#1568) test: disable es6 syntax usage within tests directory (#1569) feat(rule): add additional elements to check for incomplete with required children (#1547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phantomjs does not support the
transformcss property and so all the CSS orientation lock tests were actually false positives with the one failure being correct. Adding-webkit-transformfixes the problem.IE11 also parses CSS rule property order differently so the
testutilrule string compare would fail. Changed it to create a style on the page and compare the same properties. IE11 also didn't add a space between the CSS media properties of(layout: portrait)Closes #1384
Reviewer checks
Required fields, to be filled out by PR reviewer(s)