Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape href attribute when creating a CSS selector #1366

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 14, 2019

When creating a selector through utils.getSelector, the href attribute was not run through the escapeCSS function and so would produce improper CSS selector strings.

Closes: #1137

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: Stephen

@straker straker requested a review from a team as a code owner February 14, 2019 21:08
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's get another approval to make sure the test you updated was indeed wrong.

jeeyyy
jeeyyy previously requested changes Feb 15, 2019
lib/core/utils/get-selector.js Show resolved Hide resolved
@WilcoFiers WilcoFiers merged commit 0c2f42d into develop Feb 18, 2019
@WilcoFiers WilcoFiers deleted the fixCSSHrefSelector branch February 18, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants