This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 189
Fix symfony polyfills in scoper #2998
Merged
TomasVotruba
merged 6 commits into
deprecated-packages:master
from
pdelre:issue-2973-fix-symfony-polyfills-in-scoper
Mar 1, 2021
Merged
Fix symfony polyfills in scoper #2998
TomasVotruba
merged 6 commits into
deprecated-packages:master
from
pdelre:issue-2973-fix-symfony-polyfills-in-scoper
Mar 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI needs to pass before review |
…mfony-polyfills-in-scoper * upstream/master: [PHPStanRules] Add NoNullablePropertyRule (deprecated-packages#2999) [Rector] Clean up rector config of skip MoveVariableDeclarationNearReferenceRector (deprecated-packages#3000)
pdelre
commented
Feb 25, 2021
@@ -478,3 +478,9 @@ parameters: | |||
- packages/git-wrapper/src | |||
- packages/set-config-resolver/src/ConfigResolver.php | |||
- packages/set-config-resolver/src/SetAwareConfigResolver.php | |||
|
|||
# needed as `humbug/php-scoper` provides `Isolated\Symfony\Component\Finder\Finder` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize I've taken a liberty here, but I was unable to find a way to address humbug/php-scoper
's expected Isolated\Symfony\Component\Finder\Finder
usage.
Thank you 👍 |
I'm just building ECS prefixed and this does not work as expected. Good news, we're not alone :) php-scoper is full of reports with same issues humbug/php-scoper#440 Some fixes from dev-master of php-scoper might help, but it has not been tagged yet :/ Another attempt: a58433f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
symfony/polyfill-*
files and classes tophp-scoper
's allow lists. It addresses failure to load the polyfills detailed in #2973 & humbug/php-scoper#440.I tested this locally with the following set of commands pulled from https://github.com/symplify/symplify/blob/master/.github/workflows/build_scoped_packages.yaml#L38.
Build Scoped Package
Verify no Fatals occur