Improve @mention sanitizer for for verbatim backticks in code blocks #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropombeiro
force-pushed
the
fix/verbatim-backticks-sanitization
branch
3 times, most recently
from
109f5a3
to
5c2e262
Compare
|
The CircleCI build is failing but looks unrelated to this PR. |
|
@pombeirp thank you! Will take a look, did you rebase latest master? |
|
I did a couple of times to force a rebuild, and the build failed with different reasons each time. |
pedropombeiro
force-pushed
the
fix/verbatim-backticks-sanitization
branch
from
5c2e262
to
ff0e556
Compare
pedropombeiro
force-pushed
the
fix/verbatim-backticks-sanitization
branch
from
ff0e556
to
e289ab2
Compare
|
@feelepxyz looks like rebasing on the fix in |
feelepxyz
approved these changes
Oct 8, 2019
|
No problem, I know you guys are busy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
LinkAndMentionSanitizerso that it understands code fences with verbatim backticks which would normally derail the matching logic. Basically, the rule behind backtick code fences seems to be that the outermost delimiter is the one with most backticks, so we need to find the next occurrence with the same number of backticks in order to find the end of the code fence (see spec, confirmed in GitHub comment editor preview).Example:
Related to #1421
cc @feelepxyz