Revert "Allow #[cppgc] &mut T in sync ops"
#793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3cc4464.
lucacasonato
approved these changes
Jun 21, 2024
|
Two PRs (denoland/deno#24300 and denoland/deno#24299) have landed that use this in Deno (that are not affected by these issues). I'll try to fix this before next deno_core release, if not then we can revert the Deno changes |
|
Moved comment to #787 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #791
See #791 (review)
The following needs to be addressed before relanding:
&mut Tin the same op.try_unwrap_cppgc_objectunsafe variant.op(reentrant)