Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Reqwest 0.12 #23370

Closed
wyatt-herkamp opened this issue Apr 15, 2024 · 0 comments · Fixed by #24056
Closed

Update to Reqwest 0.12 #23370

wyatt-herkamp opened this issue Apr 15, 2024 · 0 comments · Fixed by #24056
Labels
upstream Changes in upstream are required to solve these issues

Comments

@wyatt-herkamp
Copy link

So currently Reqwest is locked to a specific version. https://github.com/denoland/deno/blob/main/Cargo.toml#L148

For that reason, I am unable to compile deno-runtime in one of my projects as I have another library that requires an updated version.

This PR seanmonstar/reqwest#2185 was merged fixing the Mac OS bug but was released in 0.12.
It would also be nice if we could get Hyper Updated and HTTP Updated and remove the locked package renames. But that is going to require a lot of refactoring from what I can tell.
@wyatt-herkamp wyatt-herkamp mentioned this issue Apr 15, 2024
Open
@bartlomieju bartlomieju added the upstream Changes in upstream are required to solve these issues label Apr 19, 2024
@lucacasonato lucacasonato mentioned this issue Jun 8, 2024
Merged
bartlomieju added a commit that referenced this issue Jun 13, 2024
@bartlomieju @ry @littledivy
chore: upgrade to reqwest 0.12.4 and rustls 0.22 (#24056)
fb31eaa 
This commit updates Deno to use `reqwest` at 0.12.4
and `rustls` at 0.22. Other related crates were updated
as well to match versions accepted by `reqwest` and `rustls`.

Note: we are not using the latest available `rustls` yet,
but this upgrade was non-trivial already, so a bump to
0.23 for `rustls` will be done in a separate commit.

Closes #23370

---------

Signed-off-by: Ryan Dahl <ry@tinyclouds.org>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
bartlomieju added a commit that referenced this issue Jun 18, 2024
@bartlomieju @ry @littledivy
chore: upgrade to reqwest 0.12.4 and rustls 0.22 (#24056)
22f2779 
This commit updates Deno to use `reqwest` at 0.12.4
and `rustls` at 0.22. Other related crates were updated
as well to match versions accepted by `reqwest` and `rustls`.

Note: we are not using the latest available `rustls` yet,
but this upgrade was non-trivial already, so a bump to
0.23 for `rustls` will be done in a separate commit.

Closes #23370

---------

Signed-off-by: Ryan Dahl <ry@tinyclouds.org>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
zebreus pushed a commit to zebreus/deno that referenced this issue Jul 8, 2024
@bartlomieju @ry
@littledivy @zebreus
chore: upgrade to reqwest 0.12.4 and rustls 0.22 (denoland#24056)
ed59838 
This commit updates Deno to use `reqwest` at 0.12.4
and `rustls` at 0.22. Other related crates were updated
as well to match versions accepted by `reqwest` and `rustls`.

Note: we are not using the latest available `rustls` yet,
but this upgrade was non-trivial already, so a bump to
0.23 for `rustls` will be done in a separate commit.

Closes denoland#23370

---------

Signed-off-by: Ryan Dahl <ry@tinyclouds.org>
Signed-off-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream Changes in upstream are required to solve these issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to reqwest 0.12.4 and rustls 0.22 bartlomieju/deno
2 participants
@wyatt-herkamp @bartlomieju