Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messagelist: use lockedQueuedEffect #3215

Closed
wants to merge 3 commits into from
Closed

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Apr 24, 2023

This is an attempt to get rid of messages like lockedEffect: fetchMoreMessagesBottom: We're locked, dropping effect which started appearing after deltachat/deltachat-core-rust#4341

@link2xt link2xt requested a review from Simon-Laux April 24, 2023 11:48
@link2xt
Copy link
Collaborator Author

link2xt commented Apr 24, 2023

I am replacing this.scheduler.queuedEffect(this.scheduler.lockedEffect( with this.scheduler.lockedQueuedEffect( here, but am not familiar with what is happening inside. The comment here suggests using lockedQueuedEffect, this is why I am doing it:

/** This effect will only get executed if the lock is unlocked. If it's still locked, this effect
* will get dropped/not executed. If you want the effect to get executed as soon as the lock with
* lockNameis unlocked, use lockedQueuedEffect.*/

@link2xt
Copy link
Collaborator Author

link2xt commented Apr 24, 2023

It seems messages are now marked as seen reliably when I select the chat, but I did no proper testing.

Nobody is using it anymore and it looks like
a wrong alternative to debouncing.
@Simon-Laux Simon-Laux requested a review from Jikstra April 24, 2023 20:27
@link2xt link2xt closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant