fix: call update_connection_history for proxified connections #6075
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/proxy-update_connection_history
branch
from
7ac39ba
to
6d3fb44
Compare
iequidoo
approved these changes
Oct 20, 2024
| /// `addr` is the string representation of IP address. | ||
| /// If connection is made over a proxy which does | ||
| /// its own DNS resolution, | ||
| /// `addr` should be the same as `host`. |
There was a problem hiding this comment.
Maybe still better an empty string? That would be shorter codewise. Why does this matter at all?
There was a problem hiding this comment.
Does not really matter, just has to be consistent so we don't get multiple entries, some for "", some for the host, some for "proxy" etc.
Hocuri
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6074