Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: protoc fix #3566

Merged
merged 1 commit into from
Aug 30, 2022
Merged

ci: protoc fix #3566

merged 1 commit into from
Aug 30, 2022

Conversation

Arqu
Copy link

@Arqu Arqu commented Aug 30, 2022

No description provided.

@Arqu Arqu force-pushed the iroh-share-ci branch 4 times, most recently from f104536 to 67e209c Compare August 30, 2022 10:39
@Hocuri
Copy link
Collaborator

Hocuri commented Aug 30, 2022

"arduino"? And what's "protoc"? Or is this an attempt to steal our ${{ secrets.GITHUB_TOKEN }} as soon as we press "Approve and run"?
Screenshot_2022-08-30_14-15-13
Ping @dignifiedquire

@Arqu
Copy link
Author

Arqu commented Aug 30, 2022

"arduino"? And what's "protoc"? Or is this an attempt to steal our ${{ secrets.GITHUB_TOKEN }} as soon as we press "Approve and run"?

Hi @Hocuri, yeah sorry for the lack of context here.

  • arduino cause they just provide a convenient action where we don't have to pollute the CI code much
  • protoc is the compiler for protobufs
  • cant steal your token, it's a magic variable that github has internally which absolves you of rate limits fetching from github/releases for protoc in this case

As for a bit more context I'm working with @dignifiedquire to make iroh-share work for deltachat and took it on me to fix some of the CI issues that come with bundling iroh code into deltachat, namely requiring a protobuf compiler.

Hope this helps :)

@Hocuri
Copy link
Collaborator

Hocuri commented Aug 30, 2022

Thanks for the clarification, and sorry for being suspicious (better be safe than sorry though), I'll leave this to the two of you then :))

@Arqu
Copy link
Author

Arqu commented Aug 30, 2022

Thanks for the clarification, and sorry for being suspicious (better be safe than sorry though), I'll leave this to the two of you then :))

Hah, no worries, totally valid! It's the perfect example of a funky PR into a PR that does weird stuff on your CI :D

@dignifiedquire dignifiedquire merged commit 8a66efb into deltachat:iroh-share Aug 30, 2022
@Arqu Arqu deleted the iroh-share-ci branch August 30, 2022 19:22
dignifiedquire pushed a commit that referenced this pull request Aug 31, 2022
dignifiedquire pushed a commit that referenced this pull request Sep 19, 2022
dignifiedquire pushed a commit that referenced this pull request Oct 5, 2022
dignifiedquire pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants