openpgp4frp uri on mac not working

[Jikstra]

For some reason the openpgp4fpr uris get slightly changed when openend on mac.
Original: B1DBA3C28FD67767738677061B6DCEF1CF5CDA98#a=delta%2Didentity%40testrun.org&g=LoginBot%20group%20%281316%29&x=k8emwgc7-4v&i=g6gjemwZ3_x&s=_3MdmNR39RP
Altered: B1DBA3C28FD67767738677061B6DCEF1CF5CDA98%23a=delta%2Didentity%40testrun.org&g=LoginBot%20group%20%281316%29&x=k8emwgc7-4v&i=g6gjemwZ3_x&s=_3MdmNR39RP

Basically the # is getting replaced with %23

[Simon-Laux]

Look like we need to use URI decode on it.

[Jikstra]

No just patch the core to handle this. The core is already handling similiar problems.

[Simon-Laux]

only the # is encoded? strange

[r10s]

closing this stale issue here, it is unclear if a core change is actually required and there is deltachat/deltachat-desktop#2257 to track the bug.

[Simon-Laux]

nope, deltachat/deltachat-desktop#2257 is a different issue:

• MacOS: open deltachat from uri doesn't detect the uri deltachat-desktop#2257 is about uri not being processed when DC isn't already open.
• This issue is about a quirk of macOS that needs special handling.

As the other uri-decoding also happens in core I believe this quirk should also be handled in the core.

[r10s]

As the other uri-decoding also happens in core I believe this quirk should also be handled in the core.

what exactly shall core do? replacing %23 by # in dc_check_qr() and related functions? that may be a lot of places, not sure if that would be the correct way to fix the issue.

[r10s]

ping @Jikstra @Simon-Laux can you please specify the actionable item in more detail? otherwise, as mentioned above, i suggest to close this issue until things are clearer.

[Simon-Laux]

can you please specify the actionable item in more detail

core should be able to also read those "escaped" qr-codes/URI's too, maybe by replacing the first %23 by #

[Simon-Laux]

not sure if that would be the correct way to fix the issue.

the "correct" way to fix would probably be inside of macOS (or maybe its a platform specific bug in electron?), but then even if apple fixes it users rely on updates to get it. so doing it in core would be faster.

[Simon-Laux]

added a workaround for this in desktop, but we should really handle that stuff in core so new clients like dc40 do not have to care about handling that macOS quirk.

[Simon-Laux]

look what I just found in the iOS source code:

let urlString = url.absoluteString
                           .replacingOccurrences(of: "openpgp4fpr", with: "OPENPGP4FPR", options: .literal, range: nil)
                           .replacingOccurrences(of: "%23", with: "#", options: .literal, range: nil)

iOS is implementing the workaround too ;)