-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve profile deletion dialog #3273
Conversation
adbenitez
commented
Aug 30, 2024
•
edited
Loading
edited
To test the changes in this pull request, install this apk: |
mmh I think the padding in the account item doesn't look good, also the account size is missing (desktop display that info) so maybe better create the item from scratch instead of trying to reuse the ContactSelectionListItem layout |
updated image capture |
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I do think we should wait with merging until the last hotfix release is about a week ago. Then we will have plenty of time left before the next release, and we don't have to do a stable-branch-dance if we need another hotfix release.