add 'verified by' to contact profiles #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
changed the title
adbenitez
added
the
enhancement
|
To test the changes in this pull request, install this apk: |
adbenitez
reviewed
Sep 25, 2023
| DcContact dcContact = dcContext.getContact(contactId); | ||
| if (dcContact.isVerified()) { | ||
| int verifierId = dcContact.getVerifierId(); | ||
| if (verifierId != 0 && verifierId != contactId) { |
There was a problem hiding this comment.
if this gets fixed in core then here we need to change and check if verifierId != SELF_CONTACT_ID
There was a problem hiding this comment.
let's see what the outcome of deltachat/deltachat-core-rust#4748 will be - if we did sth. wrong or there will be a fix in core. currently we seem to have the same state as desktop, so i think, we can merge this pr in and iterate over in a subsequent pr as needed
adbenitez
reviewed
Sep 25, 2023
adbenitez
approved these changes
Sep 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2468