Ask for the name when creating a broadcast list #2653
Conversation
Hocuri
force-pushed
the
hoc/broadcast-ask-for-name
branch
from
3f445f6
to
22a0d3d
Compare
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
|
@r10s Since we won't have a |
|
idea is that current "stabe" will be new "main" (as old "master") and use stable cores then. releases and translations will be done from "main" unstable/unrelased cores ("core-master") can be used in feature-branches (however, before being merged, should not contain a submodule usually) nightlies may be build with android-main using core-master so, to sum up: everything back to what we did the last years before introducing "stable/master" |
r10s
added
PR waiting for core
Hocuri
force-pushed
the
hoc/broadcast-ask-for-name
branch
2 times, most recently
from
22a0d3d
to
987db8d
Compare
|
To test the changes in this pull request, install this apk: |
r10s
removed
the
PR waiting for merge window
r10s
force-pushed
the
hoc/broadcast-ask-for-name
branch
from
987db8d
to
b80a938
Compare
Co-authored-by: Hocuri <hocuri@gmx.de>
There was a problem hiding this comment.
does as expected, thanks.
the avatar is currently not persisted, however, this is solved probably by deltachat/deltachat-core-rust#4644 - EDIT: not, it is not; the special handling of broadcast avatars should be removed there
once this is merged, we should create issues for desktop/ios, so things are not forgotten there
nb: i rebased the pr
|
To test the changes in this pull request, install this apk: |
feat: Make broadcast lists create their own chat - UIs need to ask for the name when creating broadcast lists now (see deltachat/deltachat-android#2653) That's quite a minimal approach: Add a List-ID header to outgoing broadcast lists, so that the receiving Delta Chat shows them as a separate chat, as talked about with @r10s and @hpk42. Done: - [x] Fix an existing bug that the chat name isn't updated when the broadcast/mailing list name changes (I already started this locally) To be done in other PRs: - [ ] Right now the receiving side shows "Mailing list" in the subtitle of such a chat, it would be nicer if it showed "Broadcast list" (or alternatively, rename "Broadcast list" to "Mailing list", too) - [ ] The UIs should probably ask for a name before creating the broadcast list, since it will actually be sent over the wire. (Android PR: deltachat/deltachat-android#2653) Fixes #4597 BREAKING CHANGE: This means that UIs need to ask for the name when creating a broadcast list, similar to deltachat/deltachat-android#2653.
|
Copying the "Delta Chat Dev" comment here: I just spent a few hours trying to make avatars work with broadcast lists, and, it's surprisingly much that has to change. One thing that's not easy to fix: In groups, we're sending out a system message everytime we add a member or change the avatar. I would prefer if we didn't need to do this for broadcast lists, esp. it's weird if everyone else gets a message after a member change in a broadcast list. However, then we will need to either (i) send the avatar with every outgoing message or (ii) remember whether there are members in the group that didn't get the avatar yet. That's why we decided to just leave Core as-is, and keep disallowing to change the profile image of broadcast lists for now (i.e. make https://github.com/deltachat/deltachat-android/pull/2653 only about the chat name, and still don't allow to change the avatar). This way, we can be sure not to introduce any new bugs right before releasing and while we would like to concentrate on OTF. |
|
To test the changes in this pull request, install this apk: |
Before deltachat/deltachat-core-rust#4644, when creating a broadcast list, the UIs didn't ask for a name since the name wasn't shown to the recipients and therefore not that important.
As of deltachat/deltachat-core-rust#4644, broadcast lists will create their own chat for the recipients, showing the broadcast lists's name, so we should ask the user for a name when creating a broadcast list.