build: enable -Werror flag when building the core #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is generally considered a bad style to use -Werror for releases because the compiler may be different, but in this case we are using always the same compiler from the NDK. |
|
To test the changes in this pull request, install this apk: |
If this flag was enabled, CI would have caught incorrect core in 1.40.0 release tag that caused crashing at start F-Droid 1.40.0 release.
link2xt
force-pushed
the
link2xt/jni-werror
branch
from
263d0af
to
86bf5a4
Compare
|
To test the changes in this pull request, install this apk: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this flag was enabled, CI would have caught
incorrect core in 1.40.0 release tag
that caused crashing at start F-Droid 1.40.0 release.