adapt videochat instance example #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- meet.jit.si is no longer usable without registration, so does not work smoothly for ad-hoc calls - basicwebrtc: protocol is no longer build-in in any app, so that example does not make sense as well this is an intermediate step, we want to get rid of the example string completely and instead show the URLs of the predefined settings. closes #2642
Simon-Laux
approved these changes
Aug 31, 2023
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meet.jit.si is no longer usable without registration, so does not work smoothly for ad-hoc calls
basicwebrtc: protocol is no longer build-in in any app, so that example does not make sense as well
this is an intermediate step,
we want to get rid of the example string completely and instead show the URLs of the predefined settings.
closes #2642
once merged, this requires
./scripts/tx-update-changed-sources.shto be run (from master, not stable!, so before, we need to merge stable to master /me still not convinced that this stable/master makes sense ... there are so many additional things that can be done wrong, once verified-one-to-ones are stable, we should reconsider thislet's treatstableas the source for translations now, even if there are some additional strings on master - otherwise, things get mixed)