Update Submodule #2619
Merged
Update Submodule #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #2616 Closes #2618 Verified 1:1 chats added a new API to Core, which DC Android now needs. So far, we only updated the submodule on a release. I think we should also update it when DC Android needs a new API introduced in Core: 1. To make builds "just work" for new contributors without having to checkout the correct commit in Core 2. To make the preview builds of the CI here work.
link2xt
approved these changes
Jul 17, 2023
|
To test the changes in this pull request, install this apk: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2616
Close #2618
Verified 1:1 chats added a new API to Core, which DC Android now needs.
So far, we only updated the submodule on a release. I think we should also update it when DC Android needs a new API that was introduced in Core:
Credits to @pjvleeuwen for bringing this problem up and exploring the different possible solutions for it!