Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix development environment #2483

Closed
wants to merge 0 commits into from
Closed

Add Nix development environment #2483

wants to merge 0 commits into from

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Feb 28, 2023

It is easier to setup and use than the Dockerfile.

@link2xt
Copy link
Contributor Author

link2xt commented Feb 28, 2023

I have put ndk-make.sh tweaks in separate PRs #2481, #2482, #2480.

@link2xt link2xt requested review from r10s and Hocuri February 28, 2023 23:38
@link2xt
Copy link
Contributor Author

link2xt commented Feb 28, 2023

We may also use https://github.com/DeterminateSystems/nix-installer-action on GitHub actions to compile preview APKs, but need to compare the performance against current https://github.com/deltachat/deltachat-android/blob/master/.github/workflows/preview-apk.yml

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@link2xt link2xt force-pushed the link2xt/nix branch 2 times, most recently from a281010 to f9b78bd Compare March 1, 2023 00:30
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

To test the changes in this pull request, install this apk:
📦 app-preview.apk

flake.nix Outdated
description = "Delta Chat for Android";

inputs = {
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest

Suggested change
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";

for stuff that's not related to NixOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here is the post explaining difference between the channels: https://discourse.nixos.org/t/differences-between-nix-channels/13998

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@link2xt
Copy link
Contributor Author

link2xt commented Mar 1, 2023

@r10s Could you check that ndk-make.sh with fixes still works for you? I want to use this dev environment to continue developing #2479

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - i am not using Docker nor Nix, so i mainly reviewed that things will work on "standard" dev environment

@link2xt
Copy link
Contributor Author

link2xt commented Mar 1, 2023

lgtm - i am not using Docker nor Nix, so i mainly reviewed that things will work on "standard" dev environment

Yes, I just want to check that it is not breaking your workflow. Docker is routinely tested by nightly building, and nix I will use for development.

@link2xt
Copy link
Contributor Author

link2xt commented Mar 1, 2023

This is actually merged, but I pushed to master first and here after rebasing, so GitHub displays this as closed.

@link2xt
Copy link
Contributor Author

link2xt commented Mar 1, 2023

Commit for reference: dc94b86

@r10s
Copy link
Member

r10s commented Mar 1, 2023

@r10s Could you check that ndk-make.sh with fixes still works for you?

@link2xt i just tried ndk-make.sh with this pr on my machine - completed successfully on my machine :)

@r10s r10s mentioned this pull request Mar 1, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants