-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nix development environment #2483
Conversation
We may also use https://github.com/DeterminateSystems/nix-installer-action on GitHub actions to compile preview APKs, but need to compare the performance against current https://github.com/deltachat/deltachat-android/blob/master/.github/workflows/preview-apk.yml |
To test the changes in this pull request, install this apk: |
a281010
to
f9b78bd
Compare
To test the changes in this pull request, install this apk: |
flake.nix
Outdated
description = "Delta Chat for Android"; | ||
|
||
inputs = { | ||
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable"; | |
nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable"; |
for stuff that's not related to NixOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, here is the post explaining difference between the channels: https://discourse.nixos.org/t/differences-between-nix-channels/13998
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - i am not using Docker nor Nix, so i mainly reviewed that things will work on "standard" dev environment
Yes, I just want to check that it is not breaking your workflow. Docker is routinely tested by nightly building, and nix I will use for development. |
This is actually merged, but I pushed to master first and here after rebasing, so GitHub displays this as closed. |
Commit for reference: dc94b86 |
It is easier to setup and use than the Dockerfile.