add dclogin scheme to qr code scan #2366
Conversation
Simon-Laux
added
the
core
Simon-Laux
removed
the
core
|
To test the changes in this pull request, install this apk: |
| @@ -791,6 +791,8 @@ | |||
| <string name="qraccount_success_enter_name">Login successful—your e-mail address is %1$s\n\nIf you like, you can now enter a name and an profile image that will be displayed to people you write to.</string> | |||
| <string name="qraccount_qr_code_cannot_be_used">The scanned QR code cannot be used to set up a new account.</string> | |||
| <string name="qraccount_use_on_new_install">The scanned QR code is for setting up a new account. You can scan the QR code when setting up a new Delta Chat installation.</string> | |||
| <string name="qrlogin_ask_login">Login to \"%1$s\"?</string> | |||
There was a problem hiding this comment.
"Login" is the noun/adjective and "Log in" the verb. this is also how we use that (mostly :) elsewhere.
There was a problem hiding this comment.
ah, that bit is not fixed, will push that directly on master before uploading the strings to transifex.
EDIT: done.
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
also first #2367 should be merged into this branch |
|
To test the changes in this pull request, install this apk: |
r10s
force-pushed
the
dc_login_scheme
branch
from
a91f182
to
525bdc6
Compare
i just rebased. |
Co-authored-by: Asiel Díaz Benítez <asieldbenitez@gmail.com>
Co-authored-by: bjoern <r10s@b44t.com>
… least already known
r10s
force-pushed
the
dc_login_scheme
branch
from
525bdc6
to
97e1955
Compare
|
To test the changes in this pull request, install this apk: |
see deltachat/interface#48 for spec.
needs a core with deltachat/deltachat-core-rust#3541 merged.
I started with android implementation mainly to add the strings that they are swiftly discussed and then translated.
Tasks
dclogin:scheme handler systemwidethose intents are beyond me, I can't figure out how to register DC as
dclogin:scheme handler systemwide. sure it needs to go intoAndroidManifest.xmlbut then the java code besides that is to hard for me. (I strongly dislike coding java) so it's better done by someone with real android experience, maybe together with #2365, as those two tasks are very similar.so feel free to just push java stuff to this branch, I'm tired and annoyed of writing java.