[Spark] Block unsupported operations on identity columns #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c27kwan
reviewed
Aug 1, 2024
spark/src/main/scala/org/apache/spark/sql/delta/commands/WriteIntoDelta.scala
Show resolved
Hide resolved
Comment on lines
58
to
63
| if (Cast.canUpCast(LongType, targetType)) { | ||
| val ex = intercept[DeltaAnalysisException] { | ||
| sql(s"ALTER TABLE $tblName $keyword COLUMN id TYPE ${targetType.sql}") | ||
| } | ||
| assert(ex.getErrorClass === "DELTA_IDENTITY_COLUMNS_ALTER_COLUMN_NOT_SUPPORTED") | ||
| } else { |
There was a problem hiding this comment.
can we do a case match on targetType instead of this?
targetType match {
case IntegerType => // foo
case DoubleType => // bar
case _ => fail("unexpected targetType")
}
c27kwan
reviewed
Aug 1, 2024
spark/src/test/scala/org/apache/spark/sql/delta/IdentityColumnAdmissionSuite.scala
Outdated
Show resolved
Hide resolved
zhipengmao-db
force-pushed
the
zhipengmao-db/identity-column-block
branch
2 times, most recently
from
60feb9d
to
d519881
Compare
5 tasks
c27kwan
reviewed
Aug 5, 2024
spark/src/main/scala/org/apache/spark/sql/delta/catalog/DeltaCatalog.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/catalog/DeltaCatalog.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/catalog/DeltaCatalog.scala
Outdated
Show resolved
Hide resolved
spark/src/main/scala/org/apache/spark/sql/delta/commands/alterDeltaTableCommands.scala
Outdated
Show resolved
Hide resolved
zhipengmao-db
force-pushed
the
zhipengmao-db/identity-column-block
branch
2 times, most recently
from
d519881
to
26c363d
Compare
c27kwan
reviewed
Aug 5, 2024
spark/src/main/scala/org/apache/spark/sql/delta/catalog/DeltaCatalog.scala
Show resolved
Hide resolved
zhipengmao-db
force-pushed
the
zhipengmao-db/identity-column-block
branch
from
26c363d
to
3431990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is part of #1959
In this PR, we block unsupported operations on identity columns including:
How was this patch tested?
A new test suite
IdentityColumnAdmissionScalaSuiteis added.Does this PR introduce any user-facing changes?
Yes. The aforementioned operations on identity columns are blocked.