fix(#2256): use consistent units of time #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update timing fields using the suffix `_ms` to be in milliseconds. Doing a quick grep through the repo I only found a few instances of this in the delete.rs file. Closes delta-io#2256
ion-elgreco
force-pushed
the
cole/issue-2256
branch
from
83bd93d
to
83316ea
Compare
|
@cmackenzie1 the metrics are optional anyways but just to get some consistency across other implementations, do you know if spark uses milli or micro precision? |
ion-elgreco
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update timing fields using the suffix
_msto be in milliseconds.Doing a quick grep through the repo I only found a few instances of this in the delete.rs file.
Related Issue(s)
Closes #2256
Documentation