Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow checkpoints to contain metadata actions without a createdTime value #2059

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Jan 8, 2024

From the protocol, createdTime is of type Option[Long] and:

The time when this metadata action is created, in milliseconds since the Unix epoch

Not required, but this only shows up when checkpoints are created and then read back into on the table load

@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Jan 8, 2024
@rtyler rtyler force-pushed the createdTime_is_optional branch 2 times, most recently from edd8d78 to dd42f23 Compare January 8, 2024 22:10
@rtyler rtyler marked this pull request as ready for review January 8, 2024 22:46
@rtyler rtyler requested a review from Blajda January 8, 2024 22:46
@rtyler rtyler enabled auto-merge (rebase) January 8, 2024 23:32
@roeap
Copy link
Collaborator

roeap commented Jan 11, 2024

The affected code is pending removal in #2037 there the created time field is treated as optional - or rather I'll make sure :).

@rtyler rtyler marked this pull request as draft January 11, 2024 19:48
auto-merge was automatically disabled January 11, 2024 19:48

Pull request was converted to draft

@rtyler rtyler marked this pull request as ready for review January 24, 2024 06:26
@rtyler rtyler enabled auto-merge (rebase) January 29, 2024 18:00
@rtyler rtyler added this to the Rust v0.17 milestone Feb 1, 2024
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…ime value

From the protocol, createdTime is of type Option[Long] and:

    The time when this metadata action is created, in milliseconds since the Unix epoch

Not required, but this only shows up when checkpoints are created and
then read back into on the table load
@rtyler rtyler merged commit f85152b into delta-io:main Feb 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants