generated from delphix/.github
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop to Main Merge - Release #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Exception Handling - Added Retries for Network calls - Reorganize the structure - Make file addition - CONTRIBUTING.md update
- Added Exception Handling - Added Retries for Network calls - Reorganize the structure - Make file addition - CONTRIBUTING.md update
#3) * Various Updates - Remove MC mentions - Specify Env Variables for Input. Clear error response. - Clean up config and installation directions * /v2 changes + management/engines API change * NR Key, Logs, Insecure Warning, Readme * minor readme * Revert python changes * Update dlpx_dct_to_nr.py * Update README.md
Also mentioned the configurable options in config.ini that can be used to configure the script
Supporting v2 of DCT API's
elima-sugunan
requested review from
arunskurian,
nick-mathison,
rohitdelphix and
gmanhas23
December 9, 2022 13:39
Update CONTRIBUTING.md and SUPPORT.md
Adding exact line for not accepting external contributions
rohitdelphix
approved these changes
Dec 14, 2022
gmanhas23
reviewed
Dec 14, 2022
gmanhas23
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOoks good to me. Just one change in moving Copyright line to the top of the file in README.md
Removing copyright from README.md following MySQL and Terraform
rohitdelphix
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Testing