-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HUBS-2073 Source changes #76
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankit-patil-hubs
requested review from
arunskurian,
sunnyx4,
Uddipaan-Hazarika,
nick-mathison and
elima-sugunan
and removed request for
arunskurian
February 28, 2024 13:41
What type of input does this value take? I assume integer? And for the two default values, if they are left blank, it will be "false" and "3"? Edit: NVM I see it in the code |
Uddipaan-Hazarika
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nick-mathison
previously requested changes
Mar 7, 2024
Uddipaan-Hazarika
approved these changes
Mar 8, 2024
Uddipaan-Hazarika
approved these changes
Mar 18, 2024
Uddipaan-Hazarika
approved these changes
Mar 21, 2024
Uddipaan-Hazarika
approved these changes
Mar 21, 2024
Uddipaan-Hazarika
approved these changes
Mar 21, 2024
kishlay-delphix
approved these changes
Mar 21, 2024
elima-sugunan
approved these changes
Mar 21, 2024
ankit-patil-hubs
dismissed
nick-mathison’s stale review
March 21, 2024 07:45
All the suggested changes are incorporated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
As the new source API needs repository id as input made changes to environment resource to persist repositories in state file.
Fedex had complained about vdb operation not working subsequently after dsource , made a change in appdata resource and oracle resource to poll the get_snapshot_by_dsourceID API after dsource job polling is completed. This will be the default behavior going forward and can be controlled by two new optional flags
Testing