Skip to content

Commit

Permalink
Merge pull request #85 from delphix-integrations/ESCL-4870
Browse files Browse the repository at this point in the history
ESCL-4870 : Terraform dsource provider doesn't support ignore_changes in the lifecycle block
  • Loading branch information
ankit-patil-hubs authored Mar 28, 2024
2 parents b0b3872 + bb42f19 commit bb67fed
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .goreleaser.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Visit https://goreleaser.com for documentation on how to customize this
# behavior.
env:
- PROVIDER_VERSION=3.2.1
- PROVIDER_VERSION=3.2.2
before:
hooks:
# this is just an example and not a requirement for provider building/publishing
Expand Down
2 changes: 1 addition & 1 deletion GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ HOSTNAME=delphix.com
NAMESPACE=dct
NAME=delphix
BINARY=terraform-provider-${NAME}
VERSION=3.2.1
VERSION=3.2.2
OS_ARCH=darwin_amd64

default: install
Expand Down
3 changes: 3 additions & 0 deletions docs/resources/appdata_dsource.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ The Appdata dSource resource allows Terraform to create and delete AppData dSour
## Upgrade Guide
* Any new dSource created post Version>=3.2.1 can set `wait_time` to wait for snapshot creation , dSources created prior to this version will not support this capability

## Note
* `status` and `enabled` are subject to change in the tfstate file based on the dSource state.

## Example Usage

The linking of a dSource can be configured through various ingestion approaches. Each configuration is customized to the connector and its supported options. The three PostgreSQL parameter sets below show working examples.
Expand Down
6 changes: 6 additions & 0 deletions docs/resources/oracle_dsource.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ The Oracle dSource resource allows Terraform to create and delete Oracle dSource
* Data Control Tower v10.0.1+ is required for dSource management. Lower versions are not supported.
* This Oracle dSource Resource only supports Oracle. See the AppData dSource Resource for the support of other connectors (i.e. AppData), such as PostgreSQL and SAP HANA. The Delphix Provider does not support SQL Server or SAP ASE.

## Upgrade Guide
* Any new dSource created post Version>=3.2.1 can set `wait_time` to wait for snapshot creation , dSources created prior to this version will not support this capability

## Note
* `status` and `enabled` are subject to change in the tfstate file based on the dSource state.

## Example Usage

* The linking of a dSource can be performed via direct ingestion as shown in the example below
Expand Down
5 changes: 0 additions & 5 deletions internal/provider/resource_appdata_dsource.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,10 +283,6 @@ func resourceAppdataDsource() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"storage_size": {
Type: schema.TypeInt,
Computed: true,
},
"plugin_version": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -529,7 +525,6 @@ func resourceDsourceRead(ctx context.Context, d *schema.ResourceData, meta inter
d.Set("database_type", result.GetDatabaseType())
d.Set("name", result.GetName())
d.Set("is_replica", result.GetIsReplica())
d.Set("storage_size", result.GetStorageSize())
d.Set("plugin_version", result.GetPluginVersion())
d.Set("creation_date", result.GetCreationDate().String())
d.Set("group_name", result.GetGroupName())
Expand Down
4 changes: 0 additions & 4 deletions internal/provider/resource_oracle_dsource.go
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,6 @@ func resourceOracleDsource() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"storage_size": {
Type: schema.TypeInt,
Computed: true,
},
"plugin_version": {
Type: schema.TypeString,
Computed: true,
Expand Down

0 comments on commit bb67fed

Please sign in to comment.