Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/k8s-resources]: support ClusterRoles and ClusterRoleBindings #618

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[stable/k8s-resources]: support ClusterRoles and ClusterRoleBindings #618

merged 1 commit into from
Oct 17, 2024

Conversation

eshepelyuk
Copy link
Contributor

@eshepelyuk eshepelyuk commented Oct 17, 2024 •
edited
Loading

Description

Adding ClusterRole and ClusterRoleBinding resources support.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@eshepelyuk eshepelyuk requested a review from a team as a code owner October 17, 2024 13:32
@eshepelyuk eshepelyuk marked this pull request as draft October 17, 2024 13:32
@eshepelyuk
[stable/k8s-resources]: support ClusterRoles and ClusterRoleBindings
2358ff4 
Signed-off-by: Ievgenii Shepeliuk <eshepelyuk@gmail.com>
@eshepelyuk eshepelyuk marked this pull request as ready for review October 17, 2024 13:40
@eshepelyuk eshepelyuk changed the title [stable/k8s-resources] feat: add ClusterRoles and ClusterRoleBindings [stable/k8s-resources]: support ClusterRoles and ClusterRoleBindings Oct 17, 2024
@eshepelyuk
Copy link
Contributor Author

@max-rocket-internet shouldn't this chart be deprecated in favour of k8s-resources ?

max-rocket-internet
max-rocket-internet approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eshepelyuk 💕

@max-rocket-internet
Copy link
Member

shouldn't this chart be deprecated in favour of k8s-resources ?

In theory I guess but I think they can coexist 🙂

@max-rocket-internet max-rocket-internet merged commit 0008a8e into deliveryhero:master Oct 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshepelyuk @max-rocket-internet