Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/k8s-event-logger]: add args to chart #609

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[stable/k8s-event-logger]: add args to chart #609

merged 2 commits into from
Oct 4, 2024

Conversation

danielbonillaquiros
Copy link
Contributor

@danielbonillaquiros danielbonillaquiros commented Oct 3, 2024 •
edited
Loading

Description

Add missing args into values.yaml
args are showing up on original repo https://github.com/max-rocket-internet/k8s-event-logger/blob/master/chart/values.yaml#L15-L16
but not in helm charts

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@danielbonillaquiros danielbonillaquiros requested a review from a team as a code owner October 3, 2024 18:38
max-rocket-internet
max-rocket-internet approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielbonillaquiros 💕

@max-rocket-internet max-rocket-internet enabled auto-merge (squash) October 4, 2024 07:22
@max-rocket-internet max-rocket-internet merged commit b1a2ad1 into deliveryhero:master Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbonillaquiros @max-rocket-internet