Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns] fix: prevent duplicate metrics #604

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[stable/node-local-dns] fix: prevent duplicate metrics #604

merged 1 commit into from
Sep 20, 2024

Conversation

msvticket
Copy link
Contributor

@msvticket msvticket commented Sep 20, 2024 •
edited
Loading

Description

Fixes #600

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@msvticket msvticket requested a review from a team as a code owner September 20, 2024 09:43
@msvticket
fix: prevent duplicate metrics
ba053d8 
also adding values documentation to README

Fixes deliveryhero#600
max-rocket-internet
max-rocket-internet approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msvticket 💚

@max-rocket-internet max-rocket-internet merged commit b648d8b into deliveryhero:master Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[node-local-dns] duplicated metrics
2 participants
@msvticket @max-rocket-internet