Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns]: Fix template rendering #564

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[stable/node-local-dns]: Fix template rendering #564

merged 1 commit into from
Feb 20, 2024

Conversation

Sarga
Copy link
Contributor

@Sarga Sarga commented Feb 20, 2024

Description

I'm really sorry; in my previous pull request I didn't test the template rendering very well.
The result was wrong
loopbind 169.254.20.25 172.20.0.10

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@Sarga Sarga requested a review from a team as a code owner February 20, 2024 09:45
@Sarga
Copy link
Contributor Author

Sarga commented Feb 20, 2024

@max-rocket-internet

max-rocket-internet
max-rocket-internet approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second time lucky 🙌

@max-rocket-internet max-rocket-internet merged commit 706f102 into deliveryhero:master Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sarga @max-rocket-internet