Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/kube-downscaler] bump version to be k8s>=1.25 ready #543

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[stable/kube-downscaler] bump version to be k8s>=1.25 ready #543

merged 2 commits into from
Nov 13, 2023

Conversation

dani-CO-CN
Copy link
Contributor

Description

Update kube-downscaler version to be able to manage Cronjobs in k8s>=1.25, after cronjob/v1beta1 removal. see the corresponding issue

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@dani-CO-CN
Update verison of kube-downscaler
533ebff 
Kube-downscaler does not propperly handle k8s>=v1.25 Cronjobs see: https://codeberg.org/hjacobs/kube-downscaler/issues/39
@dani-CO-CN dani-CO-CN requested a review from a team as a code owner November 8, 2023 23:23
max-rocket-internet
max-rocket-internet approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @dani-CO-CN 💛

@max-rocket-internet max-rocket-internet merged commit af6262f into deliveryhero:master Nov 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani-CO-CN @max-rocket-internet