Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/field-exporter]: field-exporter #539

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

vzholudev
Copy link
Contributor

@vzholudev vzholudev commented Nov 3, 2023

Description

A chart to install field-exporter. This controller is used to fill the gap in k8s-config-connector for exporting value from Config Connector managed resources into Secrets and ConfigMaps.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@vzholudev vzholudev requested a review from a team as a code owner November 3, 2023 14:30
app.kubernetes.io/component: manager
app.kubernetes.io/created-by: field-exporter
app.kubernetes.io/part-of: field-exporter
control-plane: controller-manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this label for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjunrn or @mtahaahmed can you answer this question?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helm chart was converted from kustomize. I wanted to change in the helm chart after I see it running in the cluster.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove it for now

Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @vzholudev 💚

@max-rocket-internet max-rocket-internet merged commit 43f8a98 into deliveryhero:master Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants