Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/prometheus-locust-exporter] Fix Windows non-friendly filename #528

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[stable/prometheus-locust-exporter] Fix Windows non-friendly filename #528

merged 1 commit into from
Sep 27, 2023

Conversation

ACandian
Copy link
Contributor

@ACandian ACandian commented Sep 27, 2023 •
edited
Loading

#527: Fix Windows non-friendly filename.

Description

Removed the space at the end of ".helmignore " filename to make it usable on Windows.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@max-rocket-internet max-rocket-internet marked this pull request as ready for review September 27, 2023 13:55
@max-rocket-internet max-rocket-internet requested a review from a team as a code owner September 27, 2023 13:55
max-rocket-internet
max-rocket-internet approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE 🙌

@max-rocket-internet max-rocket-internet merged commit 5bd73df into deliveryhero:master Sep 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ACandian @max-rocket-internet