Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-problem-detector]: additionalRelabelings value right place #515

Merged
merged 2 commits into from
Sep 6, 2023
Merged

[stable/node-problem-detector]: additionalRelabelings value right place #515

merged 2 commits into from
Sep 6, 2023

Conversation

r2ronoha
Copy link
Contributor

@r2ronoha r2ronoha commented Sep 6, 2023

Description

Move the additionalRelabelings value to serviceMonitor where it should be

additionalRelabelings was added to be used by the servicemonitor, and the value was misplaced under the wrong key.
This PR fixes that

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@r2ronoha r2ronoha requested a review from a team as a code owner September 6, 2023 06:56
max-rocket-internet
max-rocket-internet approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 🙌

@max-rocket-internet max-rocket-internet merged commit 940838a into deliveryhero:master Sep 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r2ronoha @max-rocket-internet