Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/node-local-dns] Changes for cilium local redirect support #510

Conversation

STASiAN
Copy link
Contributor

@STASiAN STASiAN commented Aug 29, 2023

Description

  • Return default configuration to be compatible with iptables setup.
  • add dnsServer to -localip only if setupIptables is true
  • bind to dnsServer ip only if iptables setupIptables is true

Checklist

  • [v] Title of the PR starts with chart name (e.g. [stable/mychartname])
  • [v] I have read the contribution instructions, bumped chart version and regenerated the docs
  • [v] Github actions are passing

@STASiAN STASiAN requested a review from a team as a code owner August 29, 2023 07:08
@STASiAN
Copy link
Contributor Author

STASiAN commented Aug 29, 2023

@max-rocket-internet please approve!

@max-rocket-internet
Copy link
Member

I think you should also write a better description of your change and why 🙂

@STASiAN
Copy link
Contributor Author

STASiAN commented Aug 29, 2023

I think you should also write a better description of your change and why 🙂

See my comments to your previous post

@STASiAN
Copy link
Contributor Author

STASiAN commented Aug 29, 2023

Description has been updated

@max-rocket-internet
Copy link
Member

JFYI: we are using specific configuration with cilium local-policy-redirect and don't iptables at all

OK cool but do you think changing the default behaviour of chart to suit Cilium for everyone is a good idea?

@STASiAN
Copy link
Contributor Author

STASiAN commented Aug 29, 2023

@max-rocket-internet
For now I have updated the minor version, because there have been many changes.
Is something else is required to be merged?

@STASiAN STASiAN changed the title [stable/node-local-dns] add .config.dnsServer to -localip only if config.setupIptables is true [stable/node-local-dns] Changes for cilium local redirect support Aug 29, 2023
@max-rocket-internet max-rocket-internet enabled auto-merge (squash) August 30, 2023 07:19
@max-rocket-internet max-rocket-internet merged commit 94c6dee into deliveryhero:master Aug 30, 2023
4 checks passed
@max-rocket-internet
Copy link
Member

Thanks @STASiAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants