Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Kube-Downscaler does not respect release namespace when templating
The `kube-downscaler` helm chart doesn't honor the namespace passed in to helm. This is because the chart is missing the typical metadata configuration on its kubernetes resources. ie, this problem is the same as this one for another chart: #216 To reproduce this problem: ```bash helm fetch deliveryhero/kube-downscaler --version 0.7.4 --untar=true helm template my-release kube-downscaler --namespace kube-systen > kube-downscaler.yaml ``` The `deployment.yaml` and other files will have no namespace. ie, it is not configured here: https://github.com/deliveryhero/helm-charts/blob/0b420820e3f88d5e7f9f10ddd1c9a029adb9a422/stable/kube-downscaler/templates/deployment.yaml#L3 Fix is as below: ```yaml apiVersion: apps/v1 kind: Deployment metadata: name: "{{ $fullname }}-{{ .name }}" namespace: {{ .Release.Namespace }} ```
- Loading branch information