Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request a team review #3

Open
waghanza opened this issue Sep 28, 2021 · 5 comments
Open

Request a team review #3

waghanza opened this issue Sep 28, 2021 · 5 comments

Comments

@waghanza
Copy link

Hi,

First, thanks for this github action. Very useful.

I have however an issue when trying to request review from a team.

I can see the following stacktrace in actions logs

Error: Couldn't request review.
  Error: HttpError: Validation Failed: "Could not resolve to a node with the global id of 'MDQ6VGVhbTI3OTgzNzk='."

PR assignment works well

Regards,

@waghanza
Copy link
Author

According to https://octokit.github.io/rest.js/v18#pulls-request-reviewers, team-reviwers needs to be an array of slug (org/team)

@ederfmatos-exacta
Copy link

I got the same mistake

@waghanza
Copy link
Author

@g1stavo just a doc typo

@808sAndBR
Copy link

808sAndBR commented Oct 27, 2022

For anyone else that ends up here. The above suggestions to do org/team does not fix the issue for me, it should be team by itself as the README says.

Instead what fixed this for me is to set up a PAT as is recommended (and required for assigning to teams) in the docs and using that instead of the default GITHUB_TOKEN

For context I am using it for teams within an organization where the repos are private. I do not know if this perhaps functions more along the lines of what is mentioned above if you are outside of an org setting these up?

@g1stavo
Copy link
Contributor

g1stavo commented Jan 20, 2023

Thanks @808sAndBR, indeed that's it. You need to use a personal access token with the repo scope, else you'll get the Could not resolve to a node with the global id ... error.

There's a link on the README explaining why: peter-evans/create-pull-request#155 (comment) 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants