Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $keys to the getAttributes() call to comply with laravel 5.3.17 #20

Closed
wants to merge 1 commit into from

Conversation

tomschlick
Copy link

Otherwise you get this message

ErrorException: Declaration of Delatbabel\Elocrypt\Elocrypt::getAttributes() should be compatible with Illuminate\Database\Eloquent\Model::getAttributes($keys = Array)

@tomschlick
Copy link
Author

@delatbabel any thoughts?

@delatbabel
Copy link
Owner

I'm still trying to figure out if this breaks any earlier versions, e.g. Laravel 5.1 or 5.2.

Let me get back to you or if you run any checks against those versions then let me know.

@delatbabel
Copy link
Owner

OK unfortunately this breaks against Laravel 5.1 LTS at least. So I will have to create a separate branch for this fix.

Unless of course you can convince Taylor to backport the Laravel 5.3.17 change to earlier versions. I'm not sure why he would make such a breaking change without even notifying anyone. I can't see any release note about this change. In fact the latest Laravel 5.3 API docs don't even mention this change -- the function call is described here without the $keys array:

https://github.com/laravel/framework/blob/5.3/src/Illuminate/Database/Eloquent/Model.php#L3074

@delatbabel
Copy link
Owner

OK subsequent to the above it looks like Taylor has reverted the 5.3.17 change:

laravel/framework#15813

So I will close this PR as incorporating it will break everything. You should update to a later Laravel release that has the original change reverted.

@delatbabel delatbabel closed this Oct 11, 2016
@tomschlick
Copy link
Author

Ah good catch. I didn't see that it was reverted. Thanks!

@tomschlick tomschlick deleted the patch-1 branch October 11, 2016 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants