Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--nobrk option is not supported in config.json and allowed to override code behavior in packaged mode #772

Closed
bodzhang opened this issue Sep 13, 2021 · 3 comments
Closed

--nobrk option is not supported in config.json and allowed to override code behavior in packaged mode #772

bodzhang opened this issue Sep 13, 2021 · 3 comments
Assignees
@paulcallen
Labels
area/kernel Area: Kernel severity/critical Severity: Critical status/triaged Status: Triaged

Comments

@bodzhang
Copy link
Collaborator

--nobrk option affects how Mytikos kernel handles SYS_SBRK syscall. It should be captured in remote attestation. In "packaged mode", the config.json file content is captured in the remote attestation. In current implementation, --nobrk is not supported in config.json and allowed as a command line parameter in the "package mode". The correct way is to support --nobrk configuration in config.json and reject/report-error --nobrk command line parameter in "packaged mode".
@paulcallen paulcallen added area/kernel Area: Kernel status/triaged Status: Triaged severity/critical Severity: Critical labels Sep 13, 2021
@bodzhang
Copy link
Collaborator Author

Addressed by PR #799

@bodzhang
Copy link
Collaborator Author

PR #799 did not fully address the issue. Reopen the issue.

@bodzhang bodzhang reopened this Sep 23, 2021
@bodzhang
Copy link
Collaborator Author

Addressed by PR #809

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcallen paulcallen

Labels
area/kernel Area: Kernel severity/critical Severity: Critical status/triaged Status: Triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulcallen @bodzhang