test: add tunnel tests #2535
Open
test: add tunnel tests #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
|
The tunnel connect function is currently too difficult to test. It will require some refactoring to split out the logic from the functionality to increase code coverage. |
| Name: "wrong-label", | ||
| Namespace: "", | ||
| Labels: map[string]string{ | ||
| config.ZarfConnectLabelName: "wrong", |
There was a problem hiding this comment.
Shouldn't these error?
lucasrod16
suggested changes
May 23, 2024
Comment on lines
+69
to
+75
| ti, err := c.checkForZarfConnectLabel(ctx, "good") | ||
| require.NoError(t, err) | ||
| require.Equal(t, k8s.SvcResource, ti.resourceType) | ||
| require.Equal(t, "good-service", ti.resourceName) | ||
| require.Equal(t, "good-namespace", ti.namespace) | ||
| require.Equal(t, 9090, ti.remotePort) | ||
| require.Equal(t, "foobar", ti.urlSuffix) |
There was a problem hiding this comment.
It looks like this test primarily covers the happy path. I noticed the missing-label and wrong-label test cases, and I assume you would like to test those error paths as well.
I think we can iterate over the svcs and pass in svc.Name as an argument to checkForZarfConnectLabel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests to cluster tunnel.
Related Issue
Relates to #2512
Checklist before merging