test: add unit tests for mutating webhooks #2516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucasrod16
force-pushed
the
agent-unit-tests
branch
9 times, most recently
from
db8deb0
to
7d3f2fa
Compare
lucasrod16
changed the title
lucasrod16
force-pushed
the
agent-unit-tests
branch
12 times, most recently
from
0ba2b8f
to
769ea6a
Compare
lucasrod16
force-pushed
the
agent-unit-tests
branch
from
769ea6a
to
6dbbb7d
Compare
phillebaba
previously approved these changes
May 20, 2024
There was a problem hiding this comment.
I think this looks good, a simple way of testing the admission hook.
My only nitpick is the package structure. Why are we creating yet another sub package in the http package? It seems like all of the admission related code should be contained in the same package instead of being spread out across different packages.
lucasrod16
changed the title
AustinAbro321
force-pushed
the
agent-unit-tests
branch
from
c86b62f
to
1985894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the agent's mutating webhooks
Related Issue
Relates to #2512
Checklist before merging